Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polars-lazy fails to compile with super::get_glob_start_idx error #17133

Closed
2 tasks done
nk9 opened this issue Jun 23, 2024 · 4 comments · Fixed by #17134
Closed
2 tasks done

polars-lazy fails to compile with super::get_glob_start_idx error #17133

nk9 opened this issue Jun 23, 2024 · 4 comments · Fixed by #17134
Assignees
Labels
accepted Ready for implementation bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars

Comments

@nk9
Copy link

nk9 commented Jun 23, 2024

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

This isn't failing in my code, the compiler is failing in polars-lazy-0.41.0/src/scan/parquet.rs:8:5

Log output

🕙 03:03:22 ❯ cargo build
   Compiling polars-lazy v0.41.0
error[E0432]: unresolved import `super::get_glob_start_idx`
 --> /Users/nick/.cargo/registry/src/index.crates.io-6f17d22bba15001f/polars-lazy-0.41.0/src/scan/parquet.rs:8:5
  |
8 | use super::get_glob_start_idx;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `get_glob_start_idx` in `scan`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `polars-lazy` (lib) due to 1 previous error

Issue description

polars-lazy is failing to compile. It looks like this code was just added:

7f5412a

I've tried cargo clean && cargo build as well as removing Cargo.lock, but the error persists.

Expected behavior

Successful compile.

Installed versions

polars = { version = "0.*", features = ["parquet", "lazy", "dtype-categorical", "dtype-i16"] }
polars 0.41.0
rustc 1.78.0 (9b00956e5 2024-04-29)

@nk9 nk9 added bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars labels Jun 23, 2024
@a-agmon
Copy link

a-agmon commented Jun 23, 2024

Also have the same issue

rustup 1.27.1 (54dd3d00f 2024-04-24)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.79.0 (129f3b996 2024-06-10)`
---
cargo 1.79.0 (ffa9cf99a 2024-06-03)

@ritchie46
Copy link
Member

@nameexhaustion I think there is a feature gate issue.

@ritchie46
Copy link
Member

Fix coming up. Will release a patch.

@a-agmon
Copy link

a-agmon commented Jun 23, 2024

Fix coming up. Will release a patch.

Amazing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants