depr(python): Deprecate DataFrame.as_dict positional input
#12131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deprecation
stinodego
requested review from
ritchie46,
alexander-beedie and
MarcoGorelli
as code owners
mcrumiller
added a commit
to mcrumiller/polars
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the last public function that still allowed a positional boolean input. I finally bit the bullet and marked it as keyword-only. Had to do some search&replace in our test suite as many legacy tests still use
to_dict(False).Note
If you used
to_dictextensively in your test suite, it is recommended to use our assertion utility functionassert_frame_equalinstead.