depr(python): Rename series_equal/frame_equal to equals
#12618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deprecation
stinodego
requested review from
ritchie46,
alexander-beedie and
MarcoGorelli
as code owners
alexander-beedie
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12000
I left the Rust side alone for now as that basically hits the entire test suite - I want to be sure this is the way to go before I go ahead with that.
frame_equalis a weird name as we know we have a DataFrame - we do not prefix all other methods withframeeither. It should just bedf1.equals(df2)which is clear and concise. Same forseries_equal. This also happens to correspond to whatpandasdoes.