depr(python): Rename write_database
parameter if_exists
to if_table_exists
#12783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12779.
Deprecates
if_exists
in favour ofif_table_exists
, clarifying what it is that exists.As per the linked Issue, it's not unreasonable that somebody may think they are replacing some existing data in a table. Given that the downside of getting this wrong is potentially deleting an entire table, it's good to remove the potential for ambiguity...
@stinodego: as a follow-up we should probably make the
write_database
"if_table_exists" andwrite_delta
"mode" parameters consistent, given that they have the same options/behaviour, but use different param/value names 🤔 (Can be left to a subsequent PR).