Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix repr of Expr.gather (which was still showing deprecated take) #12864

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: Fix repr of Expr.gather (which was still showing deprecated take) #12864

merged 1 commit into from
Dec 2, 2023

Conversation

MarcoGorelli
Copy link
Collaborator

On the latest release we see

In [43]: print(pl.col('a').gather(0))
col("a").take(0)

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 2, 2023
@MarcoGorelli MarcoGorelli changed the title fix: fixup repr of Expr.gather fix: fixup repr of Expr.gather (which was still showing deprecated take) Dec 2, 2023
@MarcoGorelli MarcoGorelli marked this pull request as ready for review December 2, 2023 13:50
@ritchie46 ritchie46 merged commit 78c183e into pola-rs:main Dec 2, 2023
27 checks passed
@stinodego stinodego changed the title fix: fixup repr of Expr.gather (which was still showing deprecated take) fix: Fix repr of Expr.gather (which was still showing deprecated take) Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego stinodego is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcoGorelli @ritchie46