Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Update describe to use new count implementation #12990

Merged
merged 5 commits into from
Dec 12, 2023
Merged

feat(python): Update describe to use new count implementation #12990

merged 5 commits into from
Dec 12, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Dec 11, 2023 •
edited

Ref #12935

Changes

  • The count part of the description now excludes null values
  • Series.describe() now works on an empty Series
  • Improve error message when calling describe on a DataFrame without columns
  • Refactor such that the implementation does not rely on mean, std and quantile returning null for unsupported data types.
  • Refactor tests

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Dec 11, 2023
@stinodego stinodego marked this pull request as ready for review December 11, 2023 17:55
@alexander-beedie
Copy link
Collaborator

LGTM 👌

@stinodego stinodego merged commit ac7ffa6 into main Dec 12, 2023
16 checks passed
@stinodego stinodego deleted the describe branch December 12, 2023 09:33
mcrumiller pushed a commit to mcrumiller/polars that referenced this pull request Dec 12, 2023
@stinodego @mcrumiller
feat(python): Update describe to use new count implementation (po…
2cc4083 
…la-rs#12990)
@c-peters c-peters added the accepted Ready for implementation label Dec 15, 2023
@stinodego stinodego mentioned this pull request Jan 12, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-beedie alexander-beedie alexander-beedie approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees

@stinodego stinodego

Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stinodego @alexander-beedie @c-peters