Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parse 00:00 time zone as UTC #13034

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix: Parse 00:00 time zone as UTC #13034

merged 3 commits into from
Dec 13, 2023

Conversation

MarcoGorelli
Copy link
Collaborator

closes #13032

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 13, 2023
@MarcoGorelli MarcoGorelli marked this pull request as ready for review December 13, 2023 18:31
stinodego
stinodego requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks fine! Just a comment about the testing.

stinodego
stinodego approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, looks good!

@stinodego stinodego changed the title fix: parse 00:00 in dtype as UTC fix: Parse "00:00" time zone as UTC Dec 13, 2023
@stinodego stinodego changed the title fix: Parse "00:00" time zone as UTC fix: Parse 00:00 time zone as UTC Dec 13, 2023
@stinodego stinodego merged commit 5b90db4 into pola-rs:main Dec 13, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read_avro - exceptions ComputeError: unable to parse time zone: '00:00'. Please check the Time Zone Database
2 participants
@MarcoGorelli @stinodego