fix(rust): match_chunks shouldn't change the dtype #13222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
commented
Dec 23, 2023
| @@ -481,7 +481,8 @@ where | |||
| }) | |||
| .collect(); | |||
|
|
|||
| unsafe { Self::from_chunks(self.name(), chunks) } | |||
| // SAFETY: We just slice the original chunks, their type will not change. | |||
| unsafe { Self::from_chunks_and_dtype(self.name(), chunks, self.dtype().clone()) } | |||
There was a problem hiding this comment.
The type of chunked_array should not be changed here, the previous code would infer the final type from the type of chunks, but this is not good for our logical type. For example, a DatetimeChunked will degenerate into a UInt64Chunked after being matched_chunks.
reswqa
requested review from
stinodego,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13194.