refactor(python): Refactor functionality related to Series buffers #13291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
stinodego
requested review from
ritchie46,
alexander-beedie and
MarcoGorelli
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #10718
No functional changes, no changes to the public API (it's all private stuff). Just some stuff I want refactored to more easily implement
from_buffers.Changes
_get_ptrto_get_buffer_info, as it returns the pointer, offset, and length_get_bufferas a (private) Series method - avoids excessive calls towrap_sin other places_from_bufferas a (private) Series classmethod for the same reasonBufferInfohelper struct on the Rust side.