Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(python): Clarify documentation for the agg_list argument in Expr.map_batches #13625

Merged
merged 2 commits into from
Jan 12, 2024
Merged

docs(python): Clarify documentation for the agg_list argument in Expr.map_batches #13625

merged 2 commits into from
Jan 12, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Jan 11, 2024 •
edited

This closes #13612.

Any ideas about this are welcome :).

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Jan 11, 2024
@reswqa reswqa marked this pull request as ready for review January 11, 2024 10:06
@reswqa
Copy link
Collaborator Author

reswqa commented Jan 12, 2024

@stinodego Would you mind taking a look at this one.

stinodego
stinodego approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reswqa . I made a small update to wording/formatting. Nice to have this properly explained in the docs now 👍

@reswqa
Copy link
Collaborator Author

reswqa commented Jan 12, 2024

Thanks! Excellent polishing!

@ritchie46 ritchie46 merged commit 9254510 into pola-rs:main Jan 12, 2024
14 checks passed
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
@reswqa @stinodego @r-brink
docs(python): Clarify documentation for the agg_list argument in `E…
368fa5e 
…xpr.map_batches` (pola-rs#13625)

Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify documentation for the agg_list argument in Expr.map_batches
3 participants
@reswqa @stinodego @ritchie46