Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): add note to connectorx in user-guide advising arm can't pip install #14180

Closed
wants to merge 2 commits into from

Conversation

deanm0000
Copy link
Collaborator

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Feb 1, 2024
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Feb 3, 2024

Their build targets include aarch64-unknown-linux-gnu and aarch64-apple-darwin, so let's not merge yet (and technically Apple Silicon is an ARM64 derivative and it installs fine, so it would need a small tweak to be accurate).

If it's just not shipping the wheel on Linux aarch64 architectures I'd have thought it might at least try to compile on the target machine (though that's a whole other headache, and then the suggestion to go build it yourself is absolutely correct 🤣). I'd like to confirm the platform details from the originating issue first though.

I'm also not even that sure we should be providing custom build instructions for (potentially) every optional package we reference, as this is a generic issue for less-common architectures, rather than being related to Polars itself. Presumably there are more packages that won't compile, and I can't see that it's on us to provide build instructions for all of them... (@stinodego, want to weigh-in on this one?)

@stinodego
Copy link
Member

I'm also not even that sure we should be providing custom build instructions for (potentially) every optional package we reference, as this is a generic issue for less-common architectures, rather than being related to Polars itself. Presumably there are more packages that won't compile, and I can't see that it's on us to provide build instructions for all of them... (@stinodego, want to weigh-in on this one?)

This also feels out-of-scope for me.

@deanm0000
Copy link
Collaborator Author

I just learned this word https://thedecisionlab.com/biases/bikeshedding

@stinodego
Copy link
Member

Thanks @deanm0000 for the initiative here, but this information feels a bit too specific to be included in the user guide. It's also subject to becoming outdated whenever connectorx would decide to add linux aarch wheels. So I'm closing this one.

@stinodego stinodego closed this Feb 8, 2024
@deanm0000 deanm0000 deleted the update_connectorx_docs_arm branch February 8, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants