Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: race conditions in OOC writing #14510

Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix: race conditions in OOC writing #14510

merged 2 commits into from
Feb 15, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Feb 15, 2024 •
edited
Loading

fixes #13526

  • adds a proper uuid. This wasn't the culprit, but is properly better than system time.
  • ensures we don't panic if another thread already cleared the IO buffer.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 15, 2024
@ritchie46 ritchie46 changed the title fix: use proper uuid for spill disk fix: race conditions in OOC writing Feb 15, 2024
@ritchie46 ritchie46 merged commit 1ab6fe0 into main Feb 15, 2024
17 checks passed
@ritchie46 ritchie46 deleted the pipe branch February 15, 2024 17:55
@stinodego stinodego mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego stinodego is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reading data spilled to disk may fail when multiple queries are ran in quick succession
1 participant
@ritchie46