feat(python): Change default number of rows printed in Notebooks for DataFrame/Series to 10 #14536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
stinodego
commented
Feb 16, 2024
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
imo 10 is nice and would be consistent. Also might have found another formatting inconsistency: 🤔 df = pl.DataFrame({"a": pl.int_range(0, 100, eager=True)})
ser = df.get_column("a")
|
Let's go for that. Too much vertical scrolling in a Notebook is annoying.
There are some off-by-one errors... I think I may address the HTML ones here actually if I have time, otherwise it can be a separate PR. |
stinodego
changed the title
stinodego
commented
Feb 16, 2024
Comment on lines
+66
to
+70
| half, rest = divmod(max_rows, 2) | ||
| self.row_idx = [ | ||
| *list(range(max_rows // 2)), | ||
| *list(range(half + rest)), | ||
| -1, | ||
| *list(range(df.height - max_rows // 2, df.height)), | ||
| *list(range(df.height - half, df.height)), |
There was a problem hiding this comment.
This makes sure display is correct when the limit is odd - e.g. if the limit is 9, we get 5 rows displayed, then ..., then the last 4 rows.
stinodego
commented
Feb 16, 2024
| max_rows = int(os.environ.get("POLARS_FMT_MAX_ROWS", default=25)) | ||
| max_cols = self.width | ||
|
|
||
| max_rows = int(os.environ.get("POLARS_FMT_MAX_ROWS", default=10)) |
There was a problem hiding this comment.
Default was changed here from 25 to 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14515
Changes
2010 also.I guess we could also do 10 rows for both?