Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Refactor utils/convert.py module #14739

Merged
merged 24 commits into from
Feb 28, 2024
Merged

Conversation

stinodego
Copy link
Member

Some renaming/reorganization. Also some very minor performance optimizations but none really worth mentioning. No functional changes.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 85.52632% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 81.06%. Comparing base (b4ed30b) to head (eb53514).
Report is 3 commits behind head on main.

❗ Current head eb53514 differs from pull request most recent head 78e65ee. Consider uploading reports for the commit 78e65ee to get more accurate results

Files Patch % Lines
py-polars/polars/utils/convert.py 84.52% 11 Missing and 2 partials ⚠️
py-polars/polars/datatypes/convert.py 0.00% 4 Missing ⚠️
crates/polars-plan/src/logical_plan/pyarrow.rs 50.00% 3 Missing ⚠️
py-polars/polars/series/datetime.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14739   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files        1322     1322           
  Lines      171356   171355    -1     
  Branches     2461     2456    -5     
=======================================
+ Hits       138904   138907    +3     
+ Misses      31981    31979    -2     
+ Partials      471      469    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego force-pushed the refactor-convert2 branch 3 times, most recently from 4699706 to e442b6b Compare February 28, 2024 11:44
@stinodego stinodego marked this pull request as ready for review February 28, 2024 12:17
@stinodego stinodego merged commit 066ec40 into main Feb 28, 2024
24 checks passed
@stinodego stinodego deleted the refactor-convert2 branch February 28, 2024 12:18
@c-peters c-peters added the accepted Ready for implementation label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants