docs(python): improve join_asof example #14993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters and
alexander-beedie
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14993 +/- ##
==========================================
- Coverage 80.99% 80.99% -0.01%
==========================================
Files 1333 1333
Lines 173174 173174
Branches 2458 2458
==========================================
- Hits 140265 140259 -6
- Misses 32442 32446 +4
- Partials 467 469 +2 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the current example really demonstrates what
join_asofdoes - how about showing the same example with the different strategies and commenting on how the output changes?