Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly support nulls_last + descending #15212

Merged
merged 3 commits into from Mar 22, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Mar 21, 2024

Fixes #15205.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.25%. Comparing base (0bd6ac8) to head (fafacf4).
Report is 9 commits behind head on main.

❗ Current head fafacf4 differs from pull request most recent head edefe0a. Consider uploading reports for the commit edefe0a to get more accurate results

Files Patch % Lines
...polars-core/src/chunked_array/ops/compare_inner.rs 92.30% 2 Missing ⚠️
...olars-lazy/src/physical_plan/expressions/sortby.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15212      +/-   ##
==========================================
- Coverage   81.25%   81.25%   -0.01%     
==========================================
  Files        1354     1354              
  Lines      175427   175664     +237     
  Branches     2518     2518              
==========================================
+ Hits       142545   142737     +192     
- Misses      32401    32446      +45     
  Partials      481      481              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 474ac34 into pola-rs:main Mar 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort descending breaks the nulls_last behaviour when sorting by more than one column
3 participants