Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Consistent expansion of nested struct data during DataFrame init from dict #15217

Merged
merged 1 commit into from Mar 24, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Mar 21, 2024

Closes #15192.

New test coverage added for this edge-case.

Can follow-up with a further commit that handles nested values inside nested values (the dict expansion is currently constrained to a one-level scalar fast-path that allows us to make use of extend_constant).

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (2a3b363) to head (c8aafb5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15217   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files        1354     1355    +1     
  Lines      175631   175653   +22     
  Branches     2518     2520    +2     
=======================================
+ Hits       142702   142734   +32     
+ Misses      32448    32437   -11     
- Partials      481      482    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 2484dd2 into pola-rs:main Mar 24, 2024
18 checks passed
@alexander-beedie alexander-beedie deleted the nested-struct-expansion branch March 24, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error constructing DataFrame from dict scalar
2 participants