Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly propagate strict flag when constructing a Struct Series from any values #15302

Merged
merged 3 commits into from Mar 26, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Mar 26, 2024

Also includes a bunch of tests to make sure struct construction is correct.

There is room for improvement here, but it's correct so I'll leave it for now.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (c1df38a) to head (556a52e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15302      +/-   ##
==========================================
- Coverage   81.34%   81.34%   -0.01%     
==========================================
  Files        1364     1364              
  Lines      176569   176614      +45     
  Branches     2526     2526              
==========================================
+ Hits       143632   143664      +32     
- Misses      32454    32466      +12     
- Partials      483      484       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review March 26, 2024 11:20
@stinodego stinodego merged commit a661965 into main Mar 26, 2024
23 checks passed
@stinodego stinodego deleted the fix-struct-strict branch March 26, 2024 11:36
@c-peters c-peters added the accepted Ready for implementation label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants