Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort for series with unsupported dtype should raise instead of panic #15385

Merged
merged 1 commit into from Mar 29, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Mar 29, 2024

This fixes #14465.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 83.11688% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 81.40%. Comparing base (3785fad) to head (aa0bce2).
Report is 20 commits behind head on main.

Files Patch % Lines
.../polars-core/src/series/implementations/decimal.rs 0.00% 4 Missing ⚠️
...polars-core/src/series/implementations/duration.rs 0.00% 4 Missing ⚠️
.../polars-core/src/series/implementations/boolean.rs 0.00% 2 Missing ⚠️
crates/polars-core/src/series/series_trait.rs 0.00% 2 Missing ⚠️
...es/polars-core/src/chunked_array/array/iterator.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15385      +/-   ##
==========================================
- Coverage   81.41%   81.40%   -0.02%     
==========================================
  Files        1362     1361       -1     
  Lines      176734   176512     -222     
  Branches     2531     2531              
==========================================
- Hits       143896   143688     -208     
+ Misses      32354    32340      -14     
  Partials      484      484              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f61594a into pola-rs:main Mar 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.sort() on Series of type list panicks
2 participants