Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid double-allocation in rolling_apply_agg_window #15423

Merged
merged 1 commit into from Apr 1, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (758b55a) to head (85a3d4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15423   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files        1362     1362           
  Lines      174802   174810    +8     
  Branches     2531     2531           
=======================================
+ Hits       141825   141839   +14     
+ Misses      32493    32487    -6     
  Partials      484      484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 1, 2024 15:31
@ritchie46
Copy link
Member

I think I will put a panic on the from impl and do a test run.

@ritchie46 ritchie46 merged commit effc4d6 into pola-rs:main Apr 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants