Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Move dedicated inference code out of io.database executor module #15526

Merged

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Apr 7, 2024

Some housekeeping, in advance of adding further capabilities (backing-out more accurate dtypes from the underlying db driver module when the cursor description contains a custom type_code).

This finishes consolidating inference code out of the executor module.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Apr 7, 2024
@alexander-beedie alexander-beedie changed the title refactor(python): Move inference code out of io.database executor module refactor(python): Move dedicated inference code out of io.database executor module Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 81.16%. Comparing base (4b94d2f) to head (6d16bc2).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/polars/io/database/_inference.py 35.00% 10 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15526      +/-   ##
==========================================
- Coverage   81.16%   81.16%   -0.01%     
==========================================
  Files        1362     1362              
  Lines      175015   175009       -6     
  Branches     2533     2532       -1     
==========================================
- Hits       142047   142041       -6     
- Misses      32484    32485       +1     
+ Partials      484      483       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@stinodego stinodego merged commit 293833d into pola-rs:main Apr 7, 2024
18 checks passed
@alexander-beedie alexander-beedie deleted the cleanup-database-type-inference branch April 9, 2024 10:17
@alexander-beedie alexander-beedie added the A-io-database Area: reading/writing to databases label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io-database Area: reading/writing to databases internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants