Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explode list should take validity into account #15572

Merged
merged 3 commits into from Apr 12, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Apr 10, 2024

This is annoying, but ListArray does have two layouts.

This fixes #15454.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.11%. Comparing base (44f1097) to head (89abdfb).
Report is 16 commits behind head on main.

Files Patch % Lines
...-core/src/chunked_array/ops/explode_and_offsets.rs 98.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15572      +/-   ##
==========================================
- Coverage   81.16%   81.11%   -0.06%     
==========================================
  Files        1367     1367              
  Lines      175307   174978     -329     
  Branches     2527     2530       +3     
==========================================
- Hits       142296   141939     -357     
- Misses      32534    32563      +29     
+ Partials      477      476       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 10, 2024

CodSpeed Performance Report

Merging #15572 will not alter performance

Comparing reswqa:list_explode_fix (89abdfb) with main (835d198)

Summary

✅ 22 untouched benchmarks

@reswqa reswqa marked this pull request as ready for review April 10, 2024 10:17
@ritchie46
Copy link
Member

Thanks a lot @reswqa!

@ritchie46 ritchie46 merged commit 9754225 into pola-rs:main Apr 12, 2024
26 checks passed
@reswqa reswqa deleted the list_explode_fix branch April 12, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python explode on null list outputs wrong value (from other row)
2 participants