Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rust): read_ipc memory usage tests, and writing fix #15599

Merged
merged 7 commits into from Apr 12, 2024

Conversation

itamarst
Copy link
Contributor

Fixes #15479

  • Tests for memory usage of read_ipc
  • Fix write_ipc_stream so that it uses reasonable block sizes. E.g. if the original DataFrame has a 2GB chunk, it shouldn't write out a 2GB block!

Copy link

codspeed-hq bot commented Apr 11, 2024

CodSpeed Performance Report

Merging #15599 will not alter performance

Comparing itamarst:15479-read_ipc-memory-usage-tests (beaff03) with main (c8e26ca)

Summary

✅ 22 untouched benchmarks

@itamarst itamarst marked this pull request as ready for review April 11, 2024 19:19
@itamarst itamarst changed the title bugfix(rust): read_ipc memory usage tests, and writing fix perf(rust): read_ipc memory usage tests, and writing fix Apr 11, 2024
@github-actions github-actions bot added performance Performance issues or improvements rust Related to Rust Polars labels Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.15%. Comparing base (003f4f2) to head (beaff03).

Files Patch % Lines
crates/polars-core/src/utils/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15599      +/-   ##
==========================================
- Coverage   81.15%   81.15%   -0.01%     
==========================================
  Files        1367     1367              
  Lines      174928   174939      +11     
  Branches     2530     2530              
==========================================
+ Hits       141971   141979       +8     
- Misses      32482    32485       +3     
  Partials      475      475              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itamarst itamarst requested a review from ritchie46 April 12, 2024 11:48
@ritchie46 ritchie46 merged commit 8cdacc1 into pola-rs:main Apr 12, 2024
25 checks passed
@itamarst itamarst deleted the 15479-read_ipc-memory-usage-tests branch April 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimal memory usage tests for read_ipc read_ipc_stream
3 participants