Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Remove extra thread spawn from row group fetcher #15626

Merged
merged 1 commit into from Apr 13, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Apr 13, 2024

Looked through the uses of spawn and made some small improvements

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 13, 2024
@nameexhaustion nameexhaustion changed the title perf: Remove extra thread spawn from row group fetch perf: Remove extra thread spawn from row group fetcher Apr 13, 2024
Copy link

codspeed-hq bot commented Apr 13, 2024

CodSpeed Performance Report

Merging #15626 will not alter performance

Comparing nameexhaustion:spawn (79e2424) with main (92902e6)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 98.70130% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.27%. Comparing base (b09a709) to head (79e2424).

Files Patch % Lines
crates/polars-io/src/parquet/async_impl.rs 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15626      +/-   ##
==========================================
+ Coverage   81.26%   81.27%   +0.01%     
==========================================
  Files        1371     1371              
  Lines      175779   175778       -1     
  Branches     2531     2531              
==========================================
+ Hits       142839   142856      +17     
+ Misses      32464    32447      -17     
+ Partials      476      475       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 6ec2d6e into pola-rs:main Apr 13, 2024
27 checks passed
@nameexhaustion nameexhaustion deleted the spawn branch April 13, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants