Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure 'CachedSchema' doesn't get synced between plans #15661

Merged
merged 2 commits into from Apr 15, 2024
Merged

Conversation

ritchie46
Copy link
Member

fixes #15651

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 15, 2024
Copy link

codspeed-hq bot commented Apr 15, 2024

CodSpeed Performance Report

Merging #15661 will not alter performance

Comparing cache (cfeaec1) with main (f992a7a)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.31%. Comparing base (99ab9c0) to head (cfeaec1).
Report is 7 commits behind head on main.

Files Patch % Lines
...s/polars-plan/src/logical_plan/functions/schema.rs 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15661      +/-   ##
==========================================
- Coverage   81.31%   81.31%   -0.01%     
==========================================
  Files        1373     1373              
  Lines      176254   176271      +17     
  Branches     2544     2544              
==========================================
+ Hits       143320   143330      +10     
- Misses      32452    32457       +5     
- Partials      482      484       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 2eb575b into main Apr 15, 2024
24 checks passed
@ritchie46 ritchie46 deleted the cache branch April 15, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong LazyFrame columns
1 participant