Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure we don't hold RwLock when spawning group parallelism in w… #15697

Merged
merged 1 commit into from Apr 16, 2024

Conversation

ritchie46
Copy link
Member

…indow functions

#14939

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 16, 2024
Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #15697 will not alter performance

Comparing window (84ab78c) with main (8befcd1)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (111382f) to head (84ab78c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15697      +/-   ##
==========================================
- Coverage   81.33%   81.33%   -0.01%     
==========================================
  Files        1375     1375              
  Lines      176520   176533      +13     
  Branches     2544     2544              
==========================================
+ Hits       143581   143591      +10     
+ Misses      32458    32457       -1     
- Partials      481      485       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1868c6d into main Apr 16, 2024
20 checks passed
@ritchie46 ritchie46 deleted the window branch April 16, 2024 13:09
@c-peters c-peters added the accepted Ready for implementation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants