Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure we don't hold onto Mutex when grabbing join tuples #15704

Merged
merged 4 commits into from Apr 17, 2024

Conversation

kszlim
Copy link
Contributor

@kszlim kszlim commented Apr 16, 2024

@ritchie46 fix for the usage we discussed

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 16, 2024
Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #15704 will not alter performance

Comparing kszlim:patch-4 (1efa00e) with main (2ac0da2)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (04b00e6) to head (49b8fb4).
Report is 1 commits behind head on main.

❗ Current head 49b8fb4 differs from pull request most recent head 1efa00e. Consider uploading reports for the commit 1efa00e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15704      +/-   ##
==========================================
- Coverage   81.35%   81.34%   -0.01%     
==========================================
  Files        1375     1375              
  Lines      176566   176567       +1     
  Branches     2544     2544              
==========================================
- Hits       143637   143626      -11     
- Misses      32448    32459      +11     
- Partials      481      482       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 6ba7369 into pola-rs:main Apr 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants