Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust!, python): Add context trace to LazyFrame conversion errors #15761

Merged
merged 3 commits into from Apr 19, 2024

Conversation

ritchie46
Copy link
Member

Debuggin LazyFrames just got a lot easier:

image

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Apr 19, 2024
@ritchie46 ritchie46 changed the title feat(rust!, python): Add context trace to LazyFrame conversion errors feat(rust!, python): Add context trace to LazyFrame conversion errors Apr 19, 2024
Copy link

codspeed-hq bot commented Apr 19, 2024

CodSpeed Performance Report

Merging #15761 will not alter performance

Comparing errors (ddd8f52) with main (0c2783a)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 81.35%. Comparing base (0c2783a) to head (6caab1d).
Report is 1 commits behind head on main.

❗ Current head 6caab1d differs from pull request most recent head ddd8f52. Consider uploading reports for the commit ddd8f52 to get more accurate results

Files Patch % Lines
...src/logical_plan/conversion/dsl_plan_to_ir_plan.rs 30.00% 21 Missing ⚠️
crates/polars-error/src/lib.rs 88.46% 6 Missing ⚠️
py-polars/src/error.rs 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15761      +/-   ##
==========================================
- Coverage   81.35%   81.35%   -0.01%     
==========================================
  Files        1379     1379              
  Lines      176619   176700      +81     
  Branches     2544     2542       -2     
==========================================
+ Hits       143686   143746      +60     
- Misses      32449    32472      +23     
+ Partials      484      482       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 0423fa3 into main Apr 19, 2024
24 checks passed
@ritchie46 ritchie46 deleted the errors branch April 19, 2024 09:54
@c-peters c-peters added the accepted Ready for implementation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation breaking rust Change that breaks backwards compatibility for the Rust crate enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants