Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ewm_mean_by was skipping initial nulls when it was already sorted by "by" column #15812

Merged

Conversation

MarcoGorelli
Copy link
Collaborator

On the latest release, initial null values are skipped when the dataframe is already known to be sorted by 'by', resulting in errors like

ShapeError: unable to add a column of length 4 to a DataFrame of height 5

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 21, 2024
@MarcoGorelli MarcoGorelli force-pushed the fix-ewm-mean-by-sorted-null-first branch from 70251d2 to 1faf7fd Compare April 21, 2024 08:24
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (96e1f01) to head (1faf7fd).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15812      +/-   ##
==========================================
- Coverage   81.35%   80.37%   -0.99%     
==========================================
  Files        1379     1264     -115     
  Lines      176603   165423   -11180     
  Branches     2544        0    -2544     
==========================================
- Hits       143677   132960   -10717     
- Misses      32443    32463      +20     
+ Partials      483        0     -483     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 21, 2024

CodSpeed Performance Report

Merging #15812 will degrade performances by 12.17%

Comparing MarcoGorelli:fix-ewm-mean-by-sorted-null-first (1faf7fd) with main (937fd46)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main MarcoGorelli:fix-ewm-mean-by-sorted-null-first Change
test_sort_nan_1942 1 ms 1.2 ms -12.17%

@ritchie46 ritchie46 merged commit efa92f9 into pola-rs:main Apr 21, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants