feat: Expressify dt.round
#15861
feat: Expressify dt.round
#15861
Conversation
github-actions
bot
added
enhancement
| @@ -344,7 +344,7 @@ def truncate( | |||
| @unstable() | |||
There was a problem hiding this comment.
@MarcoGorelli This function was marked as experimental since 2022-10, do you think it's stabilized now?
There was a problem hiding this comment.
sorry for the delay - I think so, yes!
| @@ -90,8 +90,8 @@ impl PyExpr { | |||
| self.inner.clone().dt().dst_offset().into() | |||
| } | |||
|
|
|||
| fn dt_round(&self, every: &str, offset: &str) -> Self { | |||
| self.inner.clone().dt().round(every, offset).into() | |||
| fn dt_round(&self, every: Self, offset: &str) -> Self { | |||
There was a problem hiding this comment.
We only expressify the every since offset is deprecated since 0.20.19.
CodSpeed Performance ReportMerging #15861 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15861 +/- ##
==========================================
+ Coverage 80.39% 81.33% +0.94%
==========================================
Files 1263 1384 +121
Lines 165368 176935 +11567
Branches 0 3033 +3033
==========================================
+ Hits 132941 143918 +10977
- Misses 32427 32531 +104
- Partials 0 486 +486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reswqa
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
No description provided.