Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move type coercion to IR conversion phase #15868

Merged
merged 1 commit into from Apr 24, 2024
Merged

refactor: Move type coercion to IR conversion phase #15868

merged 1 commit into from Apr 24, 2024

Conversation

ritchie46
Copy link
Member

Now the schema is properly resolved before we start optimizing. Also has some drive-by cleanups.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 99.15966% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.34%. Comparing base (3f58c8f) to head (31c1abb).
Report is 7 commits behind head on main.

Files Patch % Lines
...src/logical_plan/conversion/dsl_plan_to_ir_plan.rs 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15868      +/-   ##
==========================================
- Coverage   81.37%   81.34%   -0.03%     
==========================================
  Files        1378     1385       +7     
  Lines      176827   176977     +150     
  Branches     3032     3033       +1     
==========================================
+ Hits       143889   143966      +77     
- Misses      32451    32526      +75     
+ Partials      487      485       -2     
Flag Coverage Δ
python 74.71% <94.87%> (-0.03%) ⬇️
rust 78.47% <99.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit fa37e57 into main Apr 24, 2024
21 checks passed
@ritchie46 ritchie46 deleted the types branch April 24, 2024 21:18
@c-peters c-peters added the accepted Ready for implementation label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants