Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid WRITE+EXEC for CPUID check #15912

Merged
merged 1 commit into from Apr 26, 2024
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Apr 26, 2024

Our MacOS runners were failing due to invalid permissions for the mmap call. This may fix it.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 35.88%. Comparing base (fd41e03) to head (7882db9).
Report is 36 commits behind head on main.

Files Patch % Lines
py-polars/polars/_cpu_check.py 12.50% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #15912       +/-   ##
===========================================
- Coverage   80.38%   35.88%   -44.50%     
===========================================
  Files        1263     1364      +101     
  Lines      165368   167713     +2345     
  Branches        0     3032     +3032     
===========================================
- Hits       132927    60184    -72743     
- Misses      32441   107062    +74621     
- Partials        0      467      +467     
Flag Coverage Δ
python 35.88% <12.50%> (?)
rust 35.88% <12.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 99e3399 into pola-rs:main Apr 26, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants