Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): correct default in rolling_* function examples #16000

Merged
merged 1 commit into from May 2, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

The docs examples state

Compute the rolling var with the default left closure of temporal windows

although closed='right' has been the default for a while

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (075817b) to head (3daf449).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16000      +/-   ##
==========================================
+ Coverage   80.88%   80.91%   +0.02%     
==========================================
  Files        1384     1384              
  Lines      178013   178112      +99     
  Branches     3043     3043              
==========================================
+ Hits       143991   144112     +121     
+ Misses      33539    33518      -21     
+ Partials      483      482       -1     
Flag Coverage Δ
python 74.39% <ø> (+0.02%) ⬆️
rust 78.04% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review May 1, 2024 20:20
@ritchie46 ritchie46 merged commit 414e5f6 into pola-rs:main May 2, 2024
13 checks passed
AlexanderNenninger pushed a commit to AlexanderNenninger/polars that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants