Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use UnionArgs for DSL side #16017

Merged
merged 1 commit into from May 3, 2024
Merged

refactor: Use UnionArgs for DSL side #16017

merged 1 commit into from May 3, 2024

Conversation

ritchie46
Copy link
Member

Ensure we don't expose IR state to the DSL.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 80.91%. Comparing base (b7b3da6) to head (4d52575).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-plan/src/logical_plan/tree_format.rs 0.00% 8 Missing ⚠️
crates/polars-plan/src/logical_plan/options.rs 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16017   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files        1385     1385           
  Lines      178225   178245   +20     
  Branches     3050     3050           
=======================================
+ Hits       144213   144231   +18     
+ Misses      33526    33525    -1     
- Partials      486      489    +3     
Flag Coverage Δ
python 74.40% <85.00%> (+<0.01%) ⬆️
rust 78.13% <85.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 222216a into main May 3, 2024
26 checks passed
@ritchie46 ritchie46 deleted the schema branch May 3, 2024 06:27
AlexanderNenninger pushed a commit to AlexanderNenninger/polars that referenced this pull request May 3, 2024
@c-peters c-peters added the accepted Ready for implementation label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants