Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Do not close connection just because we're not returning Arrow data in batches #16031

Merged
merged 1 commit into from May 3, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented May 3, 2024

Fixes some CI failures, following a kuzu version update that exposed an error.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (222216a) to head (0a7a305).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16031      +/-   ##
==========================================
+ Coverage   80.91%   80.92%   +0.01%     
==========================================
  Files        1385     1385              
  Lines      178244   178242       -2     
  Branches     3050     3050              
==========================================
+ Hits       144229   144249      +20     
+ Misses      33526    33505      -21     
+ Partials      489      488       -1     
Flag Coverage Δ
python 74.43% <ø> (+0.02%) ⬆️
rust 78.14% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a3dedb1 into pola-rs:main May 3, 2024
15 checks passed
@alexander-beedie alexander-beedie deleted the fix-connection-close branch May 3, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants