Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Correctly handle large timedelta objects in Series constructor #16043

Merged
merged 4 commits into from May 4, 2024

Conversation

stinodego
Copy link
Member

Closes #16042

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels May 4, 2024
@stinodego stinodego marked this pull request as ready for review May 4, 2024 10:19
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (6730a72) to head (1e9ec10).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16043      +/-   ##
==========================================
- Coverage   80.96%   80.95%   -0.01%     
==========================================
  Files        1386     1386              
  Lines      178379   178386       +7     
  Branches     3064     3064              
==========================================
- Hits       144424   144413      -11     
- Misses      33466    33483      +17     
- Partials      489      490       +1     
Flag Coverage Δ
python 74.47% <100.00%> (-0.03%) ⬇️
rust 78.13% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 0ed0e8a into main May 4, 2024
17 checks passed
@stinodego stinodego deleted the fix-large-durations branch May 4, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when constructing Series with dtype Duration('ms') with large timedelta objects
1 participant