feat(python): split out rolling_*(..., by='foo') into rolling_*_by('foo', ...) #16059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
MarcoGorelli
force-pushed
the
rolling-by-python
branch
from
fc4209b
to
de2c01b
Compare
MarcoGorelli
force-pushed
the
rolling-by-python
branch
from
de2c01b
to
0c97b76
Compare
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie and
reswqa
as code owners
ritchie46
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took...quite some effort
OK if I start with the Python side, so people get the warning sooner rather than later? I've started the Rust side, it's going to take longer to complete. On the plus side, this simplifies a lot, really nice suggestion from Orson here