Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect user passed 'reader_schema' in 'scan_csv' #16080

Merged
merged 3 commits into from May 6, 2024
Merged

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented May 6, 2024

fixes #15254

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.97%. Comparing base (575e917) to head (d6550c3).

Files Patch % Lines
...s-lazy/src/physical_plan/executors/scan/parquet.rs 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16080      +/-   ##
==========================================
- Coverage   80.97%   80.97%   -0.01%     
==========================================
  Files        1386     1386              
  Lines      178439   178465      +26     
  Branches     3075     3075              
==========================================
+ Hits       144497   144513      +16     
- Misses      33451    33461      +10     
  Partials      491      491              
Flag Coverage Δ
python 74.53% <85.36%> (-0.01%) ⬇️
rust 78.13% <85.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 changed the title fix: Respect use passed 'reader_schema' in 'scan_csv' fix: Respect user passed 'reader_schema' in 'scan_csv' May 6, 2024
@ritchie46 ritchie46 merged commit dd6e2ee into main May 6, 2024
26 checks passed
@ritchie46 ritchie46 deleted the schema branch May 6, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading CSV, Polars seems to ignore the provided Schema
1 participant