Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Don't traverse deep datasets that we repr as union in CSE #16096

Merged
merged 1 commit into from May 7, 2024
Merged

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented May 7, 2024

fixes #16067

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels May 7, 2024
Copy link

codspeed-hq bot commented May 7, 2024

CodSpeed Performance Report

Merging #16096 will improve performances by 28.14%

Comparing cse (12748a1) with main (6ded6f0)

Summary

⚡ 1 improvements
✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark main cse Change
test_filter2 2.8 ms 2.2 ms +28.14%

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.97%. Comparing base (d1f3ef4) to head (12748a1).
Report is 1 commits behind head on main.

Files Patch % Lines
...lars-plan/src/logical_plan/optimizer/cse/cse_lp.rs 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16096      +/-   ##
==========================================
- Coverage   80.98%   80.97%   -0.01%     
==========================================
  Files        1386     1386              
  Lines      178465   178479      +14     
  Branches     2877     2877              
==========================================
+ Hits       144523   144532       +9     
- Misses      33450    33454       +4     
- Partials      492      493       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit c5489ac into main May 7, 2024
23 checks passed
@ritchie46 ritchie46 deleted the cse branch May 7, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance drop in collect() for LazyFrame with pl.scan_ndjson in 0.20.23
1 participant