Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check CSE name aliases for collisions. #16149

Merged
merged 3 commits into from
May 10, 2024
Merged

fix: Check CSE name aliases for collisions. #16149

merged 3 commits into from
May 10, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented May 10, 2024

Trust, but verify.

fixes #16138

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 96.47059% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.94%. Comparing base (b2291b9) to head (f180bdd).

❗ Current head f180bdd differs from pull request most recent head 416c477. Consider uploading reports for the commit 416c477 to get more accurate results

Files Patch % Lines
...rs-plan/src/logical_plan/optimizer/cse/cse_expr.rs 96.05% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16149      +/-   ##
==========================================
- Coverage   80.96%   80.94%   -0.02%     
==========================================
  Files        1386     1386              
  Lines      178492   178409      -83     
  Branches     2882     2882              
==========================================
- Hits       144508   144416      -92     
- Misses      33492    33502      +10     
+ Partials      492      491       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 changed the title fix: Fix materialization collision for cse with Series inputs fix: Check CSE name aliases for collisions. May 10, 2024
@ritchie46 ritchie46 merged commit b38aa4b into main May 10, 2024
26 checks passed
@ritchie46 ritchie46 deleted the cse branch May 10, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polars issue with optimizer (CSE)
1 participant