perf: use zeroable_vec in ewm_mean_by #16166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16166 +/- ##
=======================================
Coverage 80.99% 81.00%
=======================================
Files 1387 1387
Lines 178823 178834 +11
Branches 2877 2877
=======================================
+ Hits 144845 144861 +16
+ Misses 33486 33481 -5
Partials 492 492 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
force-pushed
the
zeroable-vec
branch
from
76576a0
to
93d7f3e
Compare
MarcoGorelli
force-pushed
the
zeroable-vec
branch
from
93d7f3e
to
403f8ef
Compare
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
MarcoGorelli
commented
May 11, 2024
|
Looks good. 👍 We definitely want to do it in a single pass indeed. Are there more of these @MarcoGorelli? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@orlp I've tried addressing your suggestion here, fancy taking a look please?