Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Move hypothesis tests into unit test module #16185

Merged
merged 3 commits into from
May 13, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 13, 2024

The idea behind this is that parametric tests should be standard operating procedure: you add a new function, write some regular unit tests, write some parametric tests. These tests should be together in the same module. That way, it's easy to see what has already been tested and where coverage might be lacking.

Controlling which tests run is done through markers (e.g. pytest -m hypothesis to run parametric tests).

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (3a630ec) to head (40ebe14).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16185   +/-   ##
=======================================
  Coverage   80.99%   80.99%           
=======================================
  Files        1392     1392           
  Lines      178930   178930           
  Branches     2897     2897           
=======================================
+ Hits       144923   144925    +2     
+ Misses      33503    33501    -2     
  Partials      504      504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review May 13, 2024 10:31
@stinodego stinodego merged commit 0654b7d into main May 13, 2024
15 checks passed
@stinodego stinodego deleted the parametric-tests branch May 13, 2024 10:39
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants