fix: Fix rolling empty group OOB #16186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
ritchie46
commented
May 13, 2024
| @@ -2785,22 +2636,6 @@ def test_datetime_cum_agg_schema() -> None: | |||
| } | |||
|
|
|||
|
|
|||
| def test_rolling_group_by_empty_groups_by_take_6330() -> None: | |||
There was a problem hiding this comment.
Moved rolling related tests to test_rolling.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16186 +/- ##
==========================================
- Coverage 80.99% 80.99% -0.01%
==========================================
Files 1392 1392
Lines 178930 178932 +2
Branches 2897 2897
==========================================
- Hits 144923 144919 -4
- Misses 33503 33509 +6
Partials 504 504 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16145