Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Enable Null datatype and null values by default in parametric testing #16192

Merged
merged 6 commits into from
May 13, 2024

Conversation

stinodego
Copy link
Member

Null values are a frequent source of bugs, so we should really be testing for them.

Changes

  • Enable Null data type by default. Dataframes/Series generated by our strategies may contain a Null column.
  • Set allow_null to True by default. This may hit some users, but we should really make the change now while people are updating their parametric tests anyway.
  • Setting allow_null=False will exlude the Null data type from the pool.
  • Adjust tests to match.

This helped me find a bug, will investigate later:
#16190

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (2e00647) to head (743140c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16192      +/-   ##
==========================================
- Coverage   81.00%   80.99%   -0.01%     
==========================================
  Files        1392     1392              
  Lines      178943   178930      -13     
  Branches     2901     2904       +3     
==========================================
- Hits       144947   144924      -23     
- Misses      33491    33503      +12     
+ Partials      505      503       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit f6b4f48 into main May 13, 2024
14 checks passed
@stinodego stinodego deleted the parametric-null branch May 13, 2024 13:54
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants