Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Move physical expressions to new crate #16306

Merged
merged 10 commits into from
May 18, 2024
Merged

refactor(rust): Move physical expressions to new crate #16306

merged 10 commits into from
May 18, 2024

Conversation

ritchie46
Copy link
Member

This will make it easier to share them between different engines that don't depend on polars-lazy.

@ritchie46 ritchie46 changed the title WIP: Move physical expressions to new crate refactor(rust): Move physical expressions to new crate May 18, 2024
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels May 18, 2024
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 72.26891% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (e214e93) to head (37855e7).
Report is 6 commits behind head on main.

Files Patch % Lines
crates/polars-core/src/datatypes/any_value.rs 0.00% 14 Missing ⚠️
py-polars/src/lazyframe/visitor/expr_nodes.rs 0.00% 12 Missing ⚠️
...rs-lazy/src/physical_plan/streaming/convert_alp.rs 0.00% 4 Missing ⚠️
crates/polars-pipe/src/pipeline/convert.rs 33.33% 2 Missing ⚠️
crates/polars-expr/src/state/execution_state.rs 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16306      +/-   ##
==========================================
+ Coverage   80.76%   81.33%   +0.56%     
==========================================
  Files        1393     1403      +10     
  Lines      179415   183295    +3880     
  Branches     2921     2924       +3     
==========================================
+ Hits       144910   149078    +4168     
+ Misses      34002    33714     -288     
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 467b885 into main May 18, 2024
25 of 26 checks passed
@ritchie46 ritchie46 deleted the reduce branch May 18, 2024 19:19
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants