fix(python): pick a consistent order for the sort options in PyIR #16350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Previously expr.sort() had a different order from expr.sortby(), which can only lead to confusion. Moreover, tighten up the types in to catch changes early.
wence-
force-pushed
the
wence/fea/sort-options-expr-consistent
branch
from
7536c29
to
cb77dec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16350 +/- ##
==========================================
- Coverage 81.37% 81.36% -0.02%
==========================================
Files 1405 1405
Lines 183738 183736 -2
Branches 2957 2957
==========================================
- Hits 149525 149496 -29
- Misses 33700 33727 +27
Partials 513 513 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously expr.sort() had a different order from expr.sortby(), which can only lead to confusion. Moreover, tighten up the types in to catch changes early.