fix(rust): describe / explain streaming plan
#16771
Merged
+206
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
coastalwhite
force-pushed
the
fix-16762-streaming-explain
branch
2 times, most recently
from
983e92e
to
c69ae0a
Compare
CodSpeed Performance ReportMerging #16771 will not alter performanceComparing Summary
|
coastalwhite
force-pushed
the
fix-16762-streaming-explain
branch
from
c69ae0a
to
315d88f
Compare
ritchie46
approved these changes
Jun 6, 2024
|
Ahg, there seems to be a test failure |
This PR adds back the possibility to `describe` / `explain` streaming engine plans. As these plans are not stored in the main `IRPlan`, there need to be special cases for that in each `describe` format. This specifically addresses it for: - Base format: Adds streaming header, prints the underlying plan - Tree format: Adds streaming header into top node, prints the underlying plan - Dot format: Prints the underlying plan Fixes pola-rs#16762
coastalwhite
force-pushed
the
fix-16762-streaming-explain
branch
from
315d88f
to
a847c40
Compare
Closed
2 tasks
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back the possibility to
describe/explainstreaming engine plans. As these plans are not stored in the mainIRPlan, there need to be special cases for that in eachdescribeformat.This specifically addresses it for:
Fixes #16762