check_for_invalid_stats_in_isnull #16776
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be in conjunction with #16766 to fix #16683 and #15323
There are really two things to fix with those issues. The first, which @nameexhaustion addressed is to stop writing bad stats but the other thing to fix is to have the reader recognize bad stats (ie when the min > max) and then ignore those stats since those files will continue to exist.
I only did one boolean function because I'm hoping there's a way to hoist the check up higher rather than having copy/paste the check in every single function. Also, I probably didn't do it optimally and wanted to get any pointers before doing anymore. I don't think I'll be able to put anymore work into this until at least next week so if someone else wants to take this over then that's fine with me.