Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entropy normalization arg #3369

Merged
merged 2 commits into from
May 11, 2022
Merged

entropy normalization arg #3369

merged 2 commits into from
May 11, 2022

Conversation

ritchie46
Copy link
Member

closes #3345

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels May 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3369 (5c64011) into master (7166080) will increase coverage by 0.01%.
The diff coverage is 87.50%.

❗ Current head 5c64011 differs from pull request most recent head bdedaf0. Consider uploading reports for the commit bdedaf0 to get more accurate results

@@            Coverage Diff             @@
##           master    #3369      +/-   ##
==========================================
+ Coverage   77.41%   77.43%   +0.01%     
==========================================
  Files         393      393              
  Lines       68343    68346       +3     
==========================================
+ Hits        52910    52921      +11     
+ Misses      15433    15425       -8     
Impacted Files Coverage Δ
py-polars/polars/internals/series.py 95.65% <50.00%> (ø)
polars/polars-core/src/series/ops/log.rs 79.41% <87.50%> (-1.24%) ⬇️
polars/polars-lazy/src/dsl/mod.rs 90.93% <100.00%> (ø)
py-polars/polars/internals/expr.py 95.12% <100.00%> (ø)
py-polars/src/lazy/dsl.rs 90.50% <100.00%> (ø)
py-polars/polars/testing.py 98.00% <0.00%> (-2.00%) ⬇️
polars/polars-lazy/src/logical_plan/aexpr.rs 80.72% <0.00%> (-0.61%) ⬇️
...src/physical_plan/executors/groupby_partitioned.rs 88.42% <0.00%> (-0.53%) ⬇️
polars/polars-lazy/src/utils.rs 80.95% <0.00%> (-0.37%) ⬇️
...olars/polars-core/src/frame/groupby/into_groups.rs 53.84% <0.00%> (-0.37%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7166080...bdedaf0. Read the comment docs.

@ritchie46 ritchie46 merged commit ca45888 into master May 11, 2022
@ritchie46 ritchie46 deleted the entropy_normalize branch May 11, 2022 16:53
moritzwilksch pushed a commit to moritzwilksch/polars that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make normalization in entropy() optional
2 participants