Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Z in native strpttime #3382

Merged
merged 1 commit into from
May 12, 2022
Merged

Allow Z in native strpttime #3382

merged 1 commit into from
May 12, 2022

Conversation

ritchie46
Copy link
Member

fixes #3380

@github-actions github-actions bot added the rust Related to Rust Polars label May 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3382 (d74ae01) into master (2045e1b) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
+ Coverage   77.47%   77.49%   +0.02%     
==========================================
  Files         394      394              
  Lines       68417    68419       +2     
==========================================
+ Hits        53006    53022      +16     
+ Misses      15411    15397      -14     
Impacted Files Coverage Δ
...lars/polars-time/src/chunkedarray/utf8/patterns.rs 0.00% <ø> (ø)
...lars/polars-time/src/chunkedarray/utf8/strptime.rs 91.21% <0.00%> (-1.25%) ⬇️
...ars/polars-core/src/chunked_array/ops/any_value.rs 69.02% <0.00%> (-0.89%) ⬇️
...e/src/chunked_array/logical/categorical/builder.rs 98.26% <0.00%> (-0.58%) ⬇️
...olars/polars-core/src/frame/groupby/into_groups.rs 54.21% <0.00%> (-0.37%) ⬇️
polars/polars-core/src/frame/asof_join/groups.rs 94.81% <0.00%> (+0.17%) ⬆️
...lars/polars-core/src/chunked_array/ops/sort/mod.rs 92.12% <0.00%> (+0.17%) ⬆️
polars/polars-arrow/src/kernels/take.rs 85.08% <0.00%> (+0.24%) ⬆️
...src/physical_plan/executors/groupby_partitioned.rs 88.94% <0.00%> (+0.52%) ⬆️
polars/polars-lazy/src/logical_plan/aexpr.rs 81.32% <0.00%> (+0.60%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2045e1b...d74ae01. Read the comment docs.

@ritchie46 ritchie46 merged commit fd49bc9 into master May 12, 2022
@ritchie46 ritchie46 deleted the add_strftime_fmt branch May 12, 2022 13:33
moritzwilksch pushed a commit to moritzwilksch/polars that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behaviour for specific type of datetime string
2 participants